Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pragma 0.8.24 #479

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Pragma 0.8.24 #479

merged 3 commits into from
Feb 13, 2024

Conversation

saucepoint
Copy link
Collaborator

Related Issue

Closes #478

Ensures that foundry will default to 0.8.24

Description of changes

  • pin 0.8.24 to foundry.toml
  • Set pragma solidity ^0.8.24; for various files which may end up hitting the TSTORE opcode (i.e. PoolManager, Hooks, and test routers)

@saucepoint saucepoint requested a review from hensha256 February 13, 2024 15:49
173759
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is so weird... something is making the gas go wrong.
But its being removed in #480 so not going to dig into it

Copy link
Contributor

@hensha256 hensha256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@saucepoint saucepoint merged commit 4a13732 into Uniswap:main Feb 13, 2024
4 checks passed
@saucepoint saucepoint deleted the pragma-0.8.24 branch February 13, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set pragma to solidity 0.8.24
2 participants